Skip to content

feat(server): encode DeepSeek V4 reasoning effort - #630

Open
pepuscz wants to merge 1 commit into
Luce-Org:mainfrom
pepuscz:feat/deepseek4-reasoning-effort
Open

feat(server): encode DeepSeek V4 reasoning effort#630
pepuscz wants to merge 1 commit into
Luce-Org:mainfrom
pepuscz:feat/deepseek4-reasoning-effort

Conversation

@pepuscz

@pepuscz pepuscz commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Add the official DeepSeek V4 Flash low, high, and max reasoning-effort encodings to the native renderer.

  • low adds no model-facing prefix
  • high and max use the official prompt prefixes
  • accepts reasoning.effort, top-level reasoning_effort, and chat_template_kwargs.reasoning_effort
  • accepts the official chat_template_kwargs.thinking switch
  • maps medium to high and x-high/xhigh to max for client compatibility
  • advertises the DeepSeek-specific effort set through /props
  • preserves the normalized effort when FlowKV rerenders a request

Official encoding reference: https://huggingface.co/deepseek-ai/DeepSeek-V4-Flash-0731/blob/main/encoding/README.md

Published qualification patches:

Validation

  • Added renderer and /props unit coverage
  • Compiled the current-main renderer and its Jinja dependencies locally, then ran focused assertions for low/high/max and thinking-disabled behavior
  • git diff --check

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

@pepuscz
pepuscz force-pushed the feat/deepseek4-reasoning-effort branch from 610b970 to 1924d7c Compare August 19, 2026 11:44
@pepuscz

pepuscz commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (e79f1b6), preserving the merged DeepSeek named-tool-call coverage while resolving the documentation and unit-test conflicts. The rebased commit is 1924d7c. Validation on the gfx1151 ROCm host: dflash_server builds successfully; test_server_unit passes 370/370; test_feature_gate passes 1/1; and the focused reasoning-prefix, tool-capability, and reasoning-capability tests each pass independently. GitHub Actions for the new head are currently awaiting maintainer approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant